tra added a comment.
Would it be possible to update the old review with the new diff? It would make
it easier to see the incremental changes you've made. If the old review can be
reopened that would be great as it would keep all relevant info in one place,
but I'm fine doing the review here, too, if phabricator does not let you do it.
================
Comment at: clang/test/SemaCUDA/bad-attributes.cu:74-75
+
+typedef __attribute__((device_builtin_surface_type)) unsigned long long s0_ty;
// expected-warning {{'device_builtin_surface_type' attribute only applies to
classes}}
+typedef __attribute__((device_builtin_texture_type)) unsigned long long t0_ty;
// expected-warning {{'device_builtin_texture_type' attribute only applies to
classes}}
+
----------------
Please add few test cases replicating use of these attributes in CUDA headers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76948/new/
https://reviews.llvm.org/D76948
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
