wmi added inline comments.
================ Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:5 +// RUN: %clang_cc1 -triple x86_64 -x c++ -S -emit-llvm -funique-internal-linkage-names -o - < %s | FileCheck %s --check-prefix=UNIQUE + +static int glob; ---------------- MaskRay wrote: > Might be worth adding a few other internal linkage names. > > * an object in an unnamed namespace > * an extern "C" static function > * a function-local static variable > * `label: &&label` > > Hope @mtrofin and @davidxl can clarify what internal names may benefit AFDO > and we can add such internal names specifically. Only internal functions matter for AFDO. Other types of internal names are irrelevant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
