aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" ---------------- jranieri-grammatech wrote: > alexfh wrote: > > bind has a side effect and returns a success status. Thus, the result being > > unused isn't necessarily a bug. Same for `connect`. And probably for > > `setjmp` as well. > In terms of bind, connect, and setjmp: while I personally would say that code > not using the return value is bugprone, the data suggests that the vast > majority of developers are using these functions in the intended manner and > the false-positive rate should be low. I think we have sufficient statistical data to suggest that these APIs should be on the list because the majority of programmers *do not* use them solely for side effects without using the return value, so my preference is to keep them in the list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76083/new/ https://reviews.llvm.org/D76083 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
