MarcusJohnson91 added a comment.

In D33029#1946761 <https://reviews.llvm.org/D33029#1946761>, @bbassi wrote:

> I don't think that's quite right. Then you will also have to have a 
> `AlignWithDanglingParenthesis` for cases when people still want closing 
> parenthesis on new line but want parameters as well as closing parenthesis to 
> be aligned with opening parenthesis. I think we need a separate option, 
> something like `BreakBeforeClosingBracket`.


I think that's the biggest problem with making changes to Clang-Format, every 
name does things that the name doesn't imply.

Here it's very similar to the bin packing options, in my case it's 
BraceWrapping.AfterExternBlock also indenting by default, making adding a 
IndentExternBlock a real pain.

I personally say fuck backwards compatibility when maintaining it requires ever 
more workarounds to fix an obviously flawed abstraction, but I'm just some dude 
and AFAIK the guys in charge support the status quo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33029/new/

https://reviews.llvm.org/D33029



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to