sdesmalen added a comment. In D76680#1959217 <https://reviews.llvm.org/D76680#1959217>, @SjoerdMeijer wrote:
> Looks good to me, but just one question about the tests. If I haven't > overlooked anything, I don't see tests that check the new diagnostics: > "argument should be the value 90 or 270" > "argument should be the value 0,90,180 or 270" > > Should they be here, or are they somewhere else? Good point, I seem to have forgotten to add these tests. I'll update the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76680/new/ https://reviews.llvm.org/D76680 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
