sammccall added inline comments.

================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:69
             struct Foo {
-              int [[b^ar]];
+              char [[b^ar]];
             };
----------------
kadircet wrote:
> any reason for changing these from int to char ?
hardcoding sizeof(int) isn't portable unless we want to set the target 
explicitly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77355/new/

https://reviews.llvm.org/D77355



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to