njames93 added a comment.

In my mind this check is definitely in the realm of the static analyser, 
clang-tidy just isn't designed for this.



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:137
    `cppcoreguidelines-avoid-goto <cppcoreguidelines-avoid-goto.html>`_,
+   `cppcoreguidelines-avoid-non-const-global-variables 
<cppcoreguidelines-avoid-non-const-global-variables.html>`_,
    `cppcoreguidelines-init-variables 
<cppcoreguidelines-init-variables.html>`_, "Yes"
----------------
All these artefacts from the add-new-check script don't need to be in here.


================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/bugprone-do-not-refer-atomic-twice.cpp:79
+
+int main() {}
----------------
don't need a main call in the test case


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77493/new/

https://reviews.llvm.org/D77493



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D77493: [clang-tidy] ... Nathan James via Phabricator via cfe-commits

Reply via email to