Szelethus added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:26-28 +#define ASSERT_STREAMSTATE_OPENED \ + assert(SS->isOpened() && \ + "Create of error node failed (only way to get this state)?"); ---------------- NoQ wrote: > Szelethus wrote: > > NoQ wrote: > > > `assertStreamStateOpened(SS);` isn't much harder to type. Can we make it > > > a function please? > > Mind that this is completely stripped from release builds, unlike a > > function call. I think. > I'd be shocked if that's the case. In LLVM we have a lot of tiny functions > all over the place and we'd better have them inlined most of the time. Ah, okay. Lets turn this into a regular function then! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits