rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed.
I agree this needs a test case. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4550 // Create the new alias itself, but don't set a name yet. + unsigned AS = cast<llvm::PointerType>(Aliasee->getType())->getAddressSpace(); auto *GA = ---------------- `Aliasee->getType()->getPointerAddressSpace()` LGTM. If we ever allow functions to declare an explicit address space, we'll need semantic checks that aliases match up, but that's okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D76182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
