pgousseau marked 2 inline comments as done. pgousseau added inline comments.
================ Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning: + _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); ---------------- RKSimon wrote: > Add a LABEL check as well Adding label sounds good, went ahead and commited without checking the test was not failing anymore, sorry will revert. ================ Comment at: clang/test/Headers/x86-header-warnings.c:3 +// in intrinsic headers. +// Preprocess file to workaround no warnings in system headers. +// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \ ---------------- thakis wrote: > Does Wsystem-headers add too much noise? Thanks for the suggestion, I did not thought about adding Wsystem-headers, I tested Wsystem-headers now though and cant seem to pick up on that particular issue without the preprocessing step. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits