aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with a few minor nits. ================ Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:117 + llvm::Expected<bool> ValueOr = get<bool>(LocalName); + if (ValueOr) { + return *ValueOr; ---------------- Elide braces ================ Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:144 + llvm::Expected<bool> ValueOr = getLocalOrGlobal<bool>(LocalName); + if (ValueOr) { + return *ValueOr; ---------------- Elide braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits