sammccall added a comment. Thanks for doing this!
================ Comment at: clang-tools-extra/clangd/unittests/YAMLTests.cpp:1 +//===-- YAMLTests.cpp - YAML container unit tests -------------------------===// +// ---------------- Ack, sorry for not mentioning this in the previous review. The YAML stuff is tested mixed together with the binary format stuff in SerializationTests.cpp. Is it possible to extend the YAML literal in that file with a synthetic Source and Cmd entry, and test it in a similar way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
