efriedma added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7683
+    if (TypeFlags.isExpandOp1SVALL()) {
+      if (Ops.size() <= 1)
+        Ops.push_back(Builder.getInt32(31));
----------------
The `Ops.size() <= 1` seems to return the same result for all the intrinsics 
you're implementing now. Does it become relevant later?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77597/new/

https://reviews.llvm.org/D77597



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to