NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Thank you! While it probably will never matter in practice because `scan-view` is barely ever updated, wouldn't it be a bit safer from revision lock perspective to keep looking for `scan-view` relative to `scan-build` but instead glob through the version number? I.e., `$RealBin/../../scan-view*/bin/scan-view`. Should we emit an error if `scan-view` is not found, instead of failing with a perl crash? Should we emit a warning if scan-build is taken from `$PATH` and is therefore of potentially mismatching version? I'll be happy to commit this as-is but these seem to be some reasonable ideas for improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77880/new/ https://reviews.llvm.org/D77880 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
