aykevl added a comment. I can't give an LGTM but at least from my perspective I very much welcome this change. I am still hitting problems with non-zero address spaces on AVR. One nit in an inline comment.
Do you plan on eventually removing `LLVM_NO_IMPLICIT_ADDRESS_SPACE` when the transition is finished? If so, I think it's worth documenting this somewhere - perhaps at llvm/lib/IR/CMakeLists.txt. ================ Comment at: llvm/include/llvm/IR/DataLayout.h:356 /// Layout pointer alignment - Align getPointerABIAlignment(unsigned AS) const; ---------------- There is no default address space in this declaration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
