tmsriram added inline comments.

================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:486-501
+  Options.BBSections =
+      llvm::StringSwitch<llvm::BasicBlockSection>(CodeGenOpts.BBSections)
+          .Case("all", llvm::BasicBlockSection::All)
+          .Case("labels", llvm::BasicBlockSection::Labels)
+          .Case("none", llvm::BasicBlockSection::None)
+          .Default(llvm::BasicBlockSection::List);
+
----------------
rsmith wrote:
> I don't like doing the parsing here. But... this is consistent with what the 
> other options above do, so I'm OK with keep it like this for consistency. (If 
> someone wants to clean this up we can do that separately for all these enum 
> options.)
Acknowledged.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68049/new/

https://reviews.llvm.org/D68049



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to