yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
================
Comment at: clang/lib/Sema/SemaCUDA.cpp:723
+ Method->addAttr(CUDADeviceAttr::CreateImplicit(Context));
+ Method->addAttr(CUDAHostAttr::CreateImplicit(Context));
+ return;
----------------
pfultz2 wrote:
> Shouldn't we add these attributes if there are no host and device attributes?
> This seems like it will treat `[]() __device__ {}` as host device.
There is check on line 716. We only reach here if there is no device and host
attrs on the function.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78655/new/
https://reviews.llvm.org/D78655
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
