aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:186-188
+ NameLookup(const NamedDecl *ND) : Data(ND, false) {}
+ NameLookup(llvm::NoneType) : Data(nullptr, true) {}
+ NameLookup(std::nullptr_t) : Data(nullptr, false) {}
----------------
Make these `explicit`?
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:44
+ virtual void storeCheckOptions(ClangTidyOptions::OptionMap &Opts) {}
+
----------------
I'd appreciate some comments here explaining when this should be overridden.
I'd also like to understand why we need `storeOptions` and `storeCheckOptions`
because the two names are so similar to one another.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73052/new/
https://reviews.llvm.org/D73052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
