dblaikie added a comment.

(peanut gallery: I'd consider, while you're touching these all anyway, changing 
them all to non-member (friended where required) as I believe that's best 
practice - allows equal implicit conversions on either side, for instance (even 
if some types have no implicit conversions - it at least provides a nice 
consistency/examples that people are likely to copy from))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78938/new/

https://reviews.llvm.org/D78938



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to