aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some minor nits. ================ Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:106 + + // Catch array subscripts with singed char -> integer conversion. + // Matcher for C arrays. ---------------- singed -> signed ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:36 +- ``signed char`` is assigned to an integer variable +- ``signed char`` and ``unsigned char`` are compared with equality/unequality operator +- ``signed char`` is converted to integer before array subscript ---------------- unequality -> inequality ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:37 +- ``signed char`` and ``unsigned char`` are compared with equality/unequality operator +- ``signed char`` is converted to integer before array subscript ---------------- to integer before array subscript -> to an integer in the array subscript Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78904/new/ https://reviews.llvm.org/D78904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
