sammccall added a comment.
LG but I think we can skip one lot of conversion, let me know what you think.
================
Comment at: clang-tools-extra/clangd/index/Background.cpp:183
const auto &IGN = IndexIt.getValue();
// Note that sources do not contain any information regarding missing
// headers, since we don't even know what absolute path they should fall
in.
----------------
is this really important enough to be worth saying twice :-)
================
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:390
PreambleSymbols.update(
- File, std::make_unique<SymbolSlab>(std::move(*IF.Symbols)),
+ *AbsPath, std::make_unique<SymbolSlab>(std::move(*IF.Symbols)),
std::make_unique<RefSlab>(),
----------------
I don't actually think it's important that we use filenames as the
PreambleSymbols sharding key. We can skip the whole resolving thing and just
use the URIs. We should go through and update docs to change "path" to "key" in
FileSymbols I guess. Am I missing something?
Sorry I think I alluded to this a bit cryptically...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79079/new/
https://reviews.llvm.org/D79079
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
