On Sat, Mar 19, 2016 at 8:29 PM, Mike Spertus <m...@spertus.com> wrote: > mspertus added a comment. > > Based on Aaron's agreement to conducting post-commit reviews, I've committed > this as revision 263890. Please let me know if I should not have done so. > (This change is a lot smaller and simpler than I feared when I commented on > my roadmap in diff http://reviews.llvm.org/D18270, so I think this is a good > inaugural post-commit review for me).
Changes in r263890 look good to me. Finding a way to generalize instead of specifying parameter counts manually would be nice but the way your commit does it is a reasonable first pass. Thanks! ~Aaron > > > http://reviews.llvm.org/D18297 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
