Anastasia added a comment. In D78979#2010527 <https://reviews.llvm.org/D78979#2010527>, @svenvh wrote:
> In D78979#2007643 <https://reviews.llvm.org/D78979#2007643>, @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we rename the flag at least? Also ideally it should be > > > documented in https://clang.llvm.org/docs/UsersManual.html#opencl-header > > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > - Driver (without `-cc1`) adds OpenCL header by default that can be > > overridden by the flag added in this patch. > > - Frontend (with `-cc1`) doesn't add the header by default but there are > > two flags `-fdeclare-opencl-builtins` or `-finclude-default-header` that > > allow to include the header. > > > The name of `-fdeclare-opencl-builtins` becomes a bit non-intuitive, a more > intuitive name would be something like `-fopencl-tablegen-builtins` perhaps > or `-fopencl-fast-builtins` if we don't want to mention TableGen. But since > it is still an experimental option, I have no objections against postponing > the renaming until the option has reached maturity. I vote for `-fopencl-fast-builtins`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
