MaskRay added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:403
switch (Linkage) {
case GlobalValue::CommonLinkage:
case GlobalValue::LinkOnceAnyLinkage:
----------------
hubert.reinterpretcast wrote:
> I have my doubts that `CommonLinkage` should produce `.weak` for XCOFF. It is
> working right because we don't actually get here from
> `PPCAIXAsmPrinter::emitGlobalVariable` for that case. I'm not sure what the
> best way would be to add an assertion here though.
Note, there is a -Wimplicit-fallthrough issue in -DLLVM_ENABLE_ASSERTIONS=off
builds which has been fixed by 31db4dbbbebd135c837014033a548eec15664ea8
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76932/new/
https://reviews.llvm.org/D76932
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
