jdoerfert added a comment. In D79186#2013689 <https://reviews.llvm.org/D79186#2013689>, @ABataev wrote:
> In D79186#2013603 <https://reviews.llvm.org/D79186#2013603>, @jdoerfert wrote: > > > What would you think about moving the allocator definitions to OMPKinds.def > > instead of listing them explicitly? As far as I can tell we really only > > distinguish between predefined and user allocators, right? > > > They also are used to find the base type 'omp_allocator_handle_t`. Also, what > do you mean saying `instead of listing them explicitly`? Anyway, you will > need to list all the predefined allocators to be able to distinguish > predefined and user-defined allocators. Sure. But we can list them once in OMPKinds.def and the use a macro wherever we need all their names (or other information). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new/ https://reviews.llvm.org/D79186 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
