On Mon, Mar 21, 2016 at 6:36 PM Eric Liu <ioe...@google.com> wrote:
> ioeric added inline comments.
>
> ================
> Comment at: unittests/Tooling/RefactoringTest.cpp:206
> @@ +205,3 @@
> +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) {
> + std::string Code = "MyType012345678901234567890123456789 *a =\n"
> + " new MyType012345678901234567890123456789();\n"
> ----------------
> klimek wrote:
> > I'd rely on the general case to be covered by the other test then, and
> just test that the style is picked up correctly (or falls back correctly to
> LLVM style).
> You are right. Shall I remove this test case for now and add general test
> cases(I mean non-unit test) for format::getStyle in the future?
>
Any reason to not add this now?
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
