jdenny marked an inline comment as done. jdenny added inline comments.
================ Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + ---------------- thopre wrote: > How about characters that cannot be part of an identifier? E.g. would "@COM:" > be interpreted as a comment? Should we only accept comment prefix if it's a > space or beginning of line before? Yes, this patch interprets `@COM:` as a comment directive. My justification is that, to keep things simple for the FileCheck user and implementation, I tried to keep parsing of comment directives and check directives as similar as possible. One intentional difference is that comment directives are ignored if they have check suffixes, such as `-NOT`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
