hyd-dev added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:99
     IO.mapOptional("InheritParentConfig", Options.InheritParentConfig);
+    IO.mapOptional("UseColor", Options.UseColor);
   }
----------------
njames93 wrote:
> I'm not entirely sure this option belongs in the config file. However if it 
> will get read in here, maybe update the help string for the command line 
> option to say it overrides the `UseColor` option from the `.clang-tidy` 
> configuration file.
> I'm not entirely sure this option belongs in the config file.
It will be useful in the config file if the user invokes clang-tidy via another 
tool that does not allow the user to set clang-tidy's command line options.
> However if it will get read in here, maybe update the help string for the 
> command line option to say it overrides the `UseColor` option from the 
> `.clang-tidy` configuration file.
I've updated it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79477/new/

https://reviews.llvm.org/D79477



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to