wanders abandoned this revision.
wanders added a comment.
In D68569#2019895 <https://reviews.llvm.org/D68569#2019895>, @MyDeveloperDay
wrote:
> Can we abandon this review now we have the style=file:<filename>?
Yes, lets abandon this.
================
Comment at: clang/lib/Format/Format.cpp:2606
+ auto Extension(llvm::sys::path::extension(FileName));
+ if (Extension != "") {
+ FilesToLookFor.push_back((Extension + ".clang-format").str());
----------------
MyDeveloperDay wrote:
> if Extension is a std::string use if (!Extension.empty())
It is a StringRef (`StringRef llvm::sys::path::extension(StringRef path)`)
but that also has `empty()`, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68569/new/
https://reviews.llvm.org/D68569
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
