hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Looks very reasonable to be. Maybe worth a release note in case this is 
surprising to any libclang users? And maybe cc the other folks from D55415 
<https://reviews.llvm.org/D55415>?



================
Comment at: clang/tools/libclang/CMakeLists.txt:65
+  else ()
+    message(FATAL_ERROR "LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA needs 
clang-tools-extra in LLVM_BUILD_PROJECTS")
+  endif ()
----------------
Isn't it LLVM_ENABLE_PROJECTS?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79599/new/

https://reviews.llvm.org/D79599



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to