SjoerdMeijer added a comment.
In D78129#2023772 <https://reviews.llvm.org/D78129#2023772>, @joelkevinjones
wrote:
> I don't think it makes sense to combine two unrelated things SVE and PA
> support into a combined thing. Since we already have UnsupportedFeatures in
> every sub-target .td file, I think it would be better to instead have:
>
> def PAUnsupported : AArch64Unsupported {
> let F = [HasPA];
> }
>
>
> and modify each .td file to have
>
> list<Predicate> UnsupportedFeatures = !listconcat(SVEUnsupported.F,
> PAUnsupported.F);
>
Can you add what Joel suggested? I don't see the point of doing this as a
follow up. This very simple thing is done half right here, so is best fixed
here as there is no reason to leave this for another time; following up on this
and talking about this is more work than just doing it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
