erichkeane added a comment.

It doesn't seem like it would be much work to move the EmitTargetMetadata 
function into the TargetInfo object (as a virtual function taking a reference 
to the collection).  Essentially, have this take a reference to the collection 
instead of the 'D' and 'GV'.

I say that,  because to me it seems that this check should likely be a part of 
that EmitTargetMetadata calling process (meaning, GV! = null is a precondition 
of this function).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77068/new/

https://reviews.llvm.org/D77068



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to