SjoerdMeijer added inline comments.
================
Comment at: clang/include/clang/Basic/arm_bf16.td:1
+//===--- arm_fp16.td - ARM FP16 compiler interface
------------------------===//
+//
----------------
typo: fp16 - > bf16?
Here, and a few more places, or is it intentional? If so, I guess that can be a
bit confusing?
================
Comment at: clang/utils/TableGen/NeonEmitter.cpp:2411
+/// is comprised of type definitions and function declarations.
+void NeonEmitter::runFP16(raw_ostream &OS) {
+ OS << "/*===---- arm_fp16.h - ARM FP16 intrinsics "
----------------
I am a bit confused here, we already have a runFP16, I am missing something?
================
Comment at: clang/utils/TableGen/NeonEmitter.cpp:2416
+ " *\n"
+ " * Permission is hereby granted, free of charge, to any person "
+ "obtaining a copy\n"
----------------
I can't remember the outcome, but I had a discussion with @sdesmalen about this
license, if this should be the new or old copyright notice. I believe, but am
not certain, that this should be the new one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79708/new/
https://reviews.llvm.org/D79708
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
