zbrid added a comment.

In D79743#2034792 <https://reviews.llvm.org/D79743#2034792>, @jyu2 wrote:

> Two questions:
>  1>   What happen under SLH, will asm goto gets removed, or a runtime problem?
>  2>   Should we emit error or warning in the Parser instead?




1. SLH crashes with an unhelpful error message.
2. I'd be happy to emit the warning in the Parser. Could you give me a pointer 
to where in the parser would be appropriate? I'm not super familiar with the 
clang codebase. Also why do you think the parser would be a better place? 
(Asking to learn since I'm new to this area)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79743/new/

https://reviews.llvm.org/D79743



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to