LukeZhuang marked 4 inline comments as done. LukeZhuang added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2049 + ConstantFP *Confidence_f = dyn_cast<ConstantFP>(Confidence); + if (!Confidence_f) { + CGM.Error(E->getArg(2)->getLocStart(), ---------------- erichkeane wrote: > This check should be able to be done during Sema. fixed in the lastest change ================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2056 + if (prob < 0.0 || prob > 1.0) { + CGM.Error(E->getArg(2)->getLocStart(), + "probability of __builtin_expect_with_probability is " ---------------- erichkeane wrote: > Same as above, we shouldn't do this during Codegen. fixed in the lastest change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits