Anastasia added inline comments.

================
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 | 
FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple 
spir-unknown-unknown 2>&1 | FileCheck %s
+// CHECK: Pass execution timing report
----------------
yaxunl wrote:
> Anastasia wrote:
> > I think conceptually it's not correct to pass spir target with C module, 
> > although it doesn't make any difference here for this test. I would still 
> > change it to some x86 one.
> if we change it to x86, it has a target machine, so the test no longer 
> reproduce the original issue.
> 
> How about add -x cl for the second command to force the source to be treated 
> as cl source code, then it can reproduce the original issue and at the same 
> time is valid for spir target?
Sure!


http://reviews.llvm.org/D17552



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to