MyDeveloperDay added a comment.

> if thats true how didn't the automated tests catch it?

If you are not in the premerge testing group the unit tests won't be run. 
(which is why I added you)

When I run the gtest it fails, I cannot see why.. but one suggestion I have is 
to drop the whole true/false its not like you have any backwards compatibility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to