hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land.
Thanks. LGTM with minor nit. In D80415#2051772 <https://reviews.llvm.org/D80415#2051772>, @stevewan wrote: > I'm planning to post an NFC patch after this to fix the formatting for > existing cases in 'aix-ld.c' so that everything is consistent. I'm not sure how NFC it is, but I would suggest removing the `-o %t.o` from the other cases as well. ================ Comment at: clang/test/Driver/aix-ld.c:184 +// RUN: --sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-ARG-ORDER %s + ---------------- Minor nit: Maybe the prefix should be `CHECK-LD32-CXX-ARG-ORDER`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
