MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added a comment.
> I would like to reiterate my discomfort with using East/West as the
> identifiers here
I'd like to think that I can see it from both angles, @steveire is correct, if
I just supply Left/Right then we'll have a request almost immediately for for
East/West, Ultimately we'll likely not know what people prefer until its been
used. (I'll be interested to do a search in github.com if I ever get this
landed)
================
Comment at: clang/lib/Format/Format.cpp:2547
+ if (Style.isCpp() || Style.Language == FormatStyle::LK_ObjC) {
+ if (Style.ConstStyle != FormatStyle::CS_Leave)
----------------
aaron.ballman wrote:
> This prevents us from using this in C code despite C having qualifiers that
> can go to the left or right of the base type but still allows you to use if
> from Objective-C. That seems incorrect.
clang-format's isCpp() covers C and C++ (and ObjectiveC and ObjectiveC++)
but you did highlight that I don't need the extra LK_ObjC check
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69764/new/
https://reviews.llvm.org/D69764
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
