amccarth marked an inline comment as done. amccarth added inline comments.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 + // SplitTemplateClosers yields better interop with GCC and GDB (PR46052). + PP.SplitTemplateClosers = true; } ---------------- sammccall wrote: > amccarth wrote: > > So, in other words, we'll always set `PP.SplitTemplateClosers` to true, now. > Yes. I thought it was clearest to write it separately in each branch, as it's > basically a coincidence and I can give a separate comment. > > Happy to fold it together if you think it's confusing. No change necessary. I agree with how you've done it. I was just amused that, after fixing the regression for CodeView, it ended up being undone for DWARF as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80554/new/ https://reviews.llvm.org/D80554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
