sylvestre.ledru added a comment.

Well done!

For Firefox, we decided to go ahead and reformat everything at once.
I has been way easier this way.

You should run flake8 & autopep8 on your python code. it isn't idomatic Python 
code (";" are useless on python for example)



================
Comment at: clang/docs/tools/generate_formatted_state.py:64
+                stdout, err = cmd.communicate();
+                if (err.find(': warning:') > 0):
+                    clean = False;
----------------
() are useless in python for if


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80627/new/

https://reviews.llvm.org/D80627



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to