jhuber6 marked an inline comment as done.
jhuber6 added a comment.
Yes, this passed all the tests on my machine at least.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:124
+ return {FnTy, Fn};
+ }
}
----------------
jdoerfert wrote:
> Are you sure we need to do the cast here? I thought clang will create it when
> it creates calls based of FunctionCallee objects. That was, to my
> understanding, the idea of the FunctionCallee thing. We might be able to just
> return {FnTy, Fn} here. If not we could always cast and return, as you noted
> a function *. Internally, only the expected type makes any sense, everything
> else will not be handled gracefully.
I tried it without and the same problem occured. The old method used
`CGM.createRuntimeFunction` which internally has a cast like this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80222/new/
https://reviews.llvm.org/D80222
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
