ymandel added a comment.

Thank you for bringing up this issue. I think it highlights an underlying 
problem -- editing templates is quite difficult -- that neither setting will 
address, as Dmitri expanded on above. Given the parallel to macros, I'd say 
your change is better than the status quo. Most clang tidies and other 
rewriting tools that I've encountered simply skip code in macro expansions, 
rather than reason about how to update the macro definition or whatnot. So, by 
that reasoning, we should skip template instantations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80961/new/

https://reviews.llvm.org/D80961



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to