eduucaldas accepted this revision. eduucaldas added inline comments.
================ Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast<Expr>(Child)) { + // This is an expression in a statement position, consume the trailing ---------------- I thought this treatement of derived class should be done by RecursiveASTVisitor This is kinda the task of WalkUpFrom*, unfortunately WalkUpFromThis follows the order: WalkUpFromBase; VisitThis; And we would've wanted the opposite order: VisitThis WalkUpFromBase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81019/new/ https://reviews.llvm.org/D81019 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits