MaskRay added a comment.

In D77168#2070334 <https://reviews.llvm.org/D77168#2070334>, @llozano wrote:

> In D77168#2070083 <https://reviews.llvm.org/D77168#2070083>, @MaskRay wrote:
>
> > In D77168#2070049 <https://reviews.llvm.org/D77168#2070049>, @jcai19 wrote:
> >
> > > In D77168#2069783 <https://reviews.llvm.org/D77168#2069783>, @MaskRay 
> > > wrote:
> > >
> > > > Do we have a mechanism bisecting pragmas? If yes, we can let that tool 
> > > > add `#pragma clang attribute push([[clang::uninitialized]], apply_to = 
> > > > variable)`
> > >
> > >
> > > Not that I am aware of unfortunately. The whole point of having this 
> > > patch is to add the ability to bisect programmatically, along the 
> > > approach of using pragma as introduced in https://reviews.llvm.org/D78693.
> >
> >
> > If we have a mechanism bisecting pragmas, this option will not be needed.
>
>
> I think you are coming late into the discussion. If you read before, We had 
> already agreed that having mechanisms for automatic triaging is "very 
> compelling". The change suggested here just makes automatic triaging much 
> easier at a very low cost.


I expressed my opinion very early in https://reviews.llvm.org/D77168#1955507  
If other reviewers find this useful even if we have a generic framework, I will 
not object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77168/new/

https://reviews.llvm.org/D77168



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to