MaskRay added a comment. Drive-by comment: the clang side change isn't tightly coupled with the LLVM side changes. It should be a separate patch.
================ Comment at: llvm/test/MC/RISCV/rvv/add.s:1 +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v < %s \ +# RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST ---------------- `< %s` -> `%s` ditto for every other test. A check prefix does not have to start with `CHECK-`. If shortening the prefix can avoid wrapped lines, probably worth considering it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
