rsmith added a comment. Your FIXME is a concern. I think it would be preferable for this function to require as a precondition that the type is complete. If the only call where that isn't true is the call from `ItaniumCXXABI::usesThreadWrapperFunction`, it seems reasonable to perform a complete-type check there before checking for trivial destructibility. When called from `Sema`, returning a conservatively-correct value here is likely to paper over bugs where a `RequireCompleteType` call is missing and a definition could be instantiated.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81313/new/ https://reviews.llvm.org/D81313 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
