thieta created this revision.
thieta added reviewers: mstorsjo, beanz, lebedev.ri.
thieta added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
As noted in https://reviews.llvm.org/D80492 that change broke standalone builds
of clang. This reverts the old behavior of libdl linking when in standalone
mode.
As a note I think it would be safe to just do:
`list(APPEND LIBS ${CMAKE_DL_LIBS})`
But I opted for the pragmatic fix this time. Let me know if you think we should
try that instead.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D81385
Files:
clang/tools/libclang/CMakeLists.txt
Index: clang/tools/libclang/CMakeLists.txt
===================================================================
--- clang/tools/libclang/CMakeLists.txt
+++ clang/tools/libclang/CMakeLists.txt
@@ -68,7 +68,12 @@
if (HAVE_LIBDL)
list(APPEND LIBS ${CMAKE_DL_LIBS})
-endif()
+elseif (CLANG_BUILT_STANDALONE)
+ find_library(DL_LIBRARY_PATH dl)
+ if (DL_LIBRARY_PATH)
+ list(APPEND LIBS dl)
+ endif ()
+endif ()
option(LIBCLANG_BUILD_STATIC
"Build libclang as a static library (in addition to a shared one)" OFF)
Index: clang/tools/libclang/CMakeLists.txt
===================================================================
--- clang/tools/libclang/CMakeLists.txt
+++ clang/tools/libclang/CMakeLists.txt
@@ -68,7 +68,12 @@
if (HAVE_LIBDL)
list(APPEND LIBS ${CMAKE_DL_LIBS})
-endif()
+elseif (CLANG_BUILT_STANDALONE)
+ find_library(DL_LIBRARY_PATH dl)
+ if (DL_LIBRARY_PATH)
+ list(APPEND LIBS dl)
+ endif ()
+endif ()
option(LIBCLANG_BUILD_STATIC
"Build libclang as a static library (in addition to a shared one)" OFF)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
