jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.
LGTM except for the nit I put in a comment.
However, I have little experience with these particular pragmas. Before
pushing, please give others a few more days in case they want to review.
================
Comment at: clang/test/AST/sourceranges.cpp:116
+ void f() {
+ // CHECK: AttributedStmt {{.*}} <line:[[@LINE-3]]:24, line:[[@LINE+2]]:33>
+ DO_PRAGMA (unroll(2))
----------------
Is there any reason not to check for `LoopHintAttr` here and on the `_Pragma`
case below? If so, I suggest a comment to explain why these cases are
different.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80944/new/
https://reviews.llvm.org/D80944
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
