fghanim marked 3 inline comments as done. fghanim added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1554 llvm::SmallVectorImpl<llvm::Value *> &) {} +bool CodeGenFunction::OMPBuilderCBHelpers::EmitOMPCopyinClause( ---------------- Note to reviewers: This keeps most of old implementation of `copyin` clause, except it uses part of the `OMPBuilder` now. Changes are noted below. ================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1582 + assert(CGF.CapturedStmtInfo->lookup(VD) && + "Copyin threadprivates should have been captured!"); + const auto *VDCanon = VD->getCanonicalDecl(); ---------------- added following few lines ================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1600 + } + + // Get the address of the threadprivate variable. ---------------- Wherever needed - changed the following section to use `OMPBuilder` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81483/new/ https://reviews.llvm.org/D81483 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits